Skip to content

fix(catalog-import): Lyngå's "Collinder nnn" joins Collinder, Harris's "Arp 2" is a common name - #680

Merged
brickbots merged 1 commit into
mainfrom
fix/catalog-lynga-collinder
Oct 24, 2026
Merged

brickbots merged 1 commit into
mainfrom
fix/catalog-lynga-collinder

Conversation

@brickbots

@brickbots brickbots commented Oct 24, 2026 •

Copy link
Copy Markdown
Owner

Part of #670. A follow-up to PR 2 (#675, merged), which left both items for this PR ("Left for later": Lyngå's "Collinder nnn" names, Harris "Arp n"). Rebased onto main after #675, #676, #677 and #678 merged.

What and why

Lyngå's "Collinder nnn". lynga_loader.identify_catalog_type knew "Col" but not "Collinder", the form Lyngå uses. So its 67 "Collinder nnn" names were stored as common names and never reached the lookup, and each of those listings became a second sky object beside its Collinder one. "Collinder" is now a designation: the listing joins its Collinder sky object, unless the match guard refuses the join.

No other long form is missing. Lyngå's designations are built from its cluster-sequence table (CLUSTER_SEQUENCE), and the only prefixes there that CATALOG_CODE_ALIASES reads are NGC, IC and Collinder. Three look like PiFinder catalogs but name other numberings, so they stay common names (the tests pin them):

  • "Lynga n": Lyngå's own clusters (Lynga 7 is a globular), not PiFinder's Lyn sequence;
  • "Harvard n": not Harris (Har);
  • "Melotte n": PiFinder has no Melotte catalog.

Harris's "Arp 2". harris_loader filed "Arp 2" (Har 133) as an Arp-catalog designation. PR 2's names rule then dropped it from Har 133's names, because it resolves to Arp's galaxy 2, another sky object (#675's guard table). But Harris's Arp 2 is the globular Arp found in the Sagittarius dwarf, so it is a common name. "Arp" is off Harris's list of catalog prefixes, so "Arp 2" is stored as a common name on Har 133 and is never a join candidate.

I checked Harris's other names (both columns, all 147 rows) for the same confusion. Only one other prefix looks like a PiFinder catalog: "Lynga 7" (Har 42), a globular found by Lyngå, which isn't Lyn 7. It was already a common name, and CATALOG_CODE_ALIASES doesn't read "lynga". Pal, Terzan, AM (Arp–Madore), E/ESO, HP, BH, Ton, Rup, Djorg, UKS, Liller and Pismis are no PiFinder catalog. The M, NGC and IC names are what they say.

Designations are written as PiFinder writes its designators (agreed with the coordinator). Both loaders used to strip the spaces from a designation ("NGC 6222" became "NGC6222"), so the joined Col 65 would have shown "Collinder65". Now a designation the lookup reads (listing_named) is written " ":

  • "Collinder 65" becomes "Col 65";
  • Lyngå's "NGC6222" and Harris's "NGC104" and "M79" become "NGC 6222", "NGC 104" and "M 79".

On the sky object a listing joins, that repeats the listing's own name, which the device already drops when it loads names (§9.3). It is the same rule in both loaders, with no table of long forms: parse_designation already maps "collinder" to Col. A designation the lookup doesn't read keeps the old unspaced form; no row of Lyngå's or Harris's sources has one.

docs/ax/catalog.md has no sentence about either loader's identification or spelling, so it is unchanged.

Data effect

On today's main (with #675, #676, #677 and #678), plus this PR: the import builds in 32 s, with 0 corrections and 14 match-guard rejections. Findings go 1,366 (main before wave 1) → 1,253. The numbers below compare against PR 2's build alone, as this PR was written.

Built from python/ with python -m PiFinder.catalog_imports.main, starting from the committed DB. Compared with PR 2's build (pifinder-pr2.db, its findings), by row sets, not bytes.

  • Log. 34 warnings (PR 2: 32): the guard's 14 rejections, against PR 2's 12. No errors.
  • Rows.
    • objects 149,312 → 149,248 (−64, the joins);
    • catalog_objects 151,170 (unchanged);
    • names 430,128 → 430,126: −3 "Collinder nnn" on the three refused listings, +1 "Arp 2".
  • No object's type, position, magnitude or first name (names[0]) changes. Two sizes are filled (below).

Findings: 1,329 → 1,329 (0 removed, 0 added)

findings.py gives the same 1,329 findings in every category. 23 keep their identity but change their payload: their catalog_names lose a Lyngå or Harris unspaced repeat ("NGC0869"'s "NGC869 [Lyn]", "NGC0104"'s "NGC104 [Har]"…). On M 13, "M 13 [Har]" takes the place of "NGC6205 [Har]" (see Names).

  • 15 are name findings: IC 2944, M 13, M 17, M 44, M 7, NGC 104, 1977, 2301, 457, 4609, 4755, 6819, 7023, 869, 884.
  • 8 are name_catalog_only findings: NGC 1502, 2244, 2281, 2362, 2419, 2516, 7510, 7789.

Lyngå → Collinder: 64 of 67 join

Every join #675 predicted happens, and so do the three rejections it predicted. Lyn 91 and Lyn 92 join Col 33 and Col 34. Those became sky objects of their own in PR 2, when the guard refused their "IC1848".

Joins 10′ or more apart:

listing sky object separation limit
Lyn 163 Col 65 25.9′ 220′
Lyn 780 Col 367 18.7′ 40′
Lyn 155 Col 464 17.1′ 120′
Lyn 529 Col 223 16.0′ 30′
Lyn 505 Col 213 13.2′ 30′
Lyn 350 Col 467 12.1′ 30′
Lyn 735 Col 338 10.3′ 30′
Lyn 55 Col 21 (Ast) 10.1′ 30′
Lyn 406 Col 173 10.0′ 370′

The other 55 lie within 10′, 33 of them within 1′.

Fills (fill-only, §9.1): two sizes, no magnitudes.

  • Col 240: 24′ (Lyngå's), where Collinder has none;
  • Col 463: 36′.

Every other joined Col object already had a magnitude and size, except that Col 95 and Col 471 have no magnitude in either source.

Match guard: 3 new rejections, 1 gone

listing aka → sky object why verdict
Lyn 829 (OC) "Col 394" → Col 394 (OC, 22′) 39.2′, limit 30′ Rejected because of a Collinder source error; needs a correction. collinder.txt has 18 52 28, −20°59′28″. SIMBAD has Collinder 394 at 18 52 22.1, −20°13′44″: collinder.txt is 45.8′ off in declination, with its RA right. Lyngå's −20°23′ is 18.4′ from SIMBAD. PR 7: Col 394's position. Lyn 829 then joins.
Lyn 855 (OC) "Col 401" → Col 401 (OC, 1′) 40.0′, limit 30′ Rejected because of a Collinder source error; needs a correction. This is the declination #675 flagged as "probably wrong". SIMBAD has Collinder 401 at +00°19′00″; Lyngå has +00°20′ (1′ off); collinder.txt's −00°20′ is 39′ off. PR 7: Col 401's declination. Lyn 855 then joins.
Lyn 639 (OC) "Col 285" → Col 285 (OC, no size) 1,221.9′, limit 30′ Needs a decision (Rich). One group, two centres: collinder2.txt calls Col 285 the Ursa Major Moving Group, and collinder.txt places it at 12 03, +58° (the Big Dipper's core). Lyngå, and SIMBAD after it (C 1440+697), put it at 14 40.9, +69°34′, 20° away. Neither gives a size, so the guard's 30′ applies. A same_as correction would make them one sky object; without one they stay two. Rich decided: one object, by a PR 7 same_as.
Har 133 (Gb) "Arp2" → Arp 2 (Gx) Gone: "Arp 2" is no longer a join candidate.

PR 2's other 11 rejections are unchanged; Lyngå's three now log their akas spaced ("NGC 6222", "NGC 6846", "NGC 6996").

Har 133's names

names
committed DB (built before #671) Arp 2, UGC 10310, Har 133, Arp2: Har 133 sat on Arp's galaxy 2
PR 2 Har 133 (the guard refuses the join, and the names rule drops "Arp2")
this PR Har 133, Arp 2

Har 133 stays a sky object of its own (19 28 44.1, −30°21′14″), not Arp's galaxy 2.

Names: 572 respelled

loader prefix respelled example
Lyngå NGC 347 Lyn 1000: NGC7790 → NGC 7790
Lyngå IC 25 Lyn 111: IC348 → IC 348
Lyngå Collinder → Col 64 Lyn 163: Collinder 65 → Col 65
Harris NGC 104 Har 1: NGC104 → NGC 104
Harris M 29 Har 10: M79 → M 79
Harris IC 3 Har 33: IC4499 → IC 4499
total 572

What the device shows (names after it drops repeats) goes from 429,208 to 428,720:

  • −450 unspaced NGC/IC near-duplicates. "NGC 869" and "NGC869" on one object becomes "NGC 869" once. One on each of 450 objects.
  • −64 on the joins. The Lyngå listing's own object, with its "Lyn n" and "Collinder n", is gone. "Lyn n" moves to the Collinder object, and "Col n" repeats that object's own name.
  • −3 "Collinder nnn" on the three refused listings, and +1 "Arp 2".
  • +28 "M nn" on Messier globulars. Steinicke stores M numbers unspaced (steinicke_loader.py: "M" + m_sequence), so Harris's spaced "M 13" no longer repeats it. M 13 now shows "M13" and "M 13", where it showed "NGC 6205" and "NGC6205". The number of near-duplicates there stays the same, they just move. EGC already writes "M 54", so on M 54 nothing new appears. Spacing Steinicke's M names would remove all 28 (see below).

Left for PR 7

Corrections (SIMBAD-cited above):

Lyn 639 / Col 285, the Ursa Major Moving Group: same_as (Rich decided: one sky object).

Left for later

  • Steinicke's unspaced "M13". With it spaced, the 28 globulars above lose their "M13"/"M 13" pair. That is the Steinicke loader (PR 3) or the names work (PR 6), not this PR.
  • Collinder's "nl" names. Col 62 and Col 65 carry a name "nl", collinder.txt's "nl" placeholder read as a name. It is the Collinder loader's, and predates this PR.
  • Joined objects whose magnitudes disagree. Fill-only keeps Collinder's. The audit has no verdicts on these:
    • Col 419: 7.6 against Lyngå's 5.4;
    • Col 316: 6.6 against 3.4;
    • Col 467: 10.1 against 11.8;
    • Col 468: 11.0 against 13.4.

Testing

  • tests/test_catalog_matching.py, 14 new tests, on fixtures (never the committed DB):

    • Lyngå's identification: "Collinder 65" → "Col 65", NGC and IC spaced, and "Lynga 7", "Harvard 5", "Melotte 20" kept as common names;
    • Harris's identification: NGC, M and IC spaced, and "Arp 2", "Pal 1", "Lynga 7" kept as common names;
    • load_lynga on Lyngå's own rows for Lyn 163 and Lyn 855:
      • Lyn 163 joins Col 65, and its "Col 65" repeats the object's name;
      • Lyn 855 is refused by Col 401 (collinder.txt's −00°20′) and does not carry "Col 401";
    • load_harris on Harris's rows for Arp 2 and NGC 6401, with Arp's galaxy 2 present: Har 133 keeps "Arp 2", nothing is rejected, and NGC 6401 gets "NGC 6401".

    9 of the 14 fail on fix(catalog-import): match guard, fill-only precedence, and names that resolve #675's loaders; the other 5 pin names that were already common names.

  • nox -s lint, format, type_hints, smoke_tests (5 passed) and unit_tests (1,789 passed): all green.

  • A local DB build, compared with PR 2's DB and findings.py against PR 2's findings, as above. The DB is not committed (PR 7).

🤖 Generated with Claude Code

Base automatically changed from fix/catalog-matching-precedence to main October 24, 2026 16:42
…s "Arp 2" is a common name

Lyngå spells Collinder out, and its loader knew only "Col", so its 67
"Collinder nnn" names were common names that never reached the lookup.
They are designations now: 64 of those listings join their Collinder sky
object, and the match guard refuses three (Lyn 639 to Col 285, Lyn 829 to
Col 394, Lyn 855 to Col 401), whose Collinder positions disagree with
Lyngå's.

Harris filed "Arp 2" as an Arp designation, so the names rule dropped it
from Har 133: it resolves to Arp's galaxy 2. Harris's Arp 2 is the
globular Arp found in the Sagittarius dwarf, so it is a common name now,
and no join candidate.

Both loaders write a designation the lookup reads as PiFinder writes its
designators, "<catalog code> <sequence>": "Collinder 65" is "Col 65",
Lyngå's "NGC6222" and Harris's "NGC104" and "M79" are "NGC 6222",
"NGC 104" and "M 79". On a joined sky object they repeat that listing's
own name, which the device drops when it loads names.

Refs #670

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@brickbots
brickbots force-pushed the fix/catalog-lynga-collinder branch from 12875bc to 3cb5935 Compare October 24, 2026 16:51
@brickbots
brickbots merged commit c355928 into main Oct 24, 2026
4 checks passed
brickbots added a commit that referenced this pull request Nov 10, 2026
…d stricter correction checks (#694)

* feat(catalog-corrections): the 84 hip identifications the star rules miss

One table per designator, in the file of the source it lists: SAC's
doubles and red stars, TLK, RASC's doubles and WDS. Each cites the
Hipparcos star in SIMBAD and gives #685's evidence as its why. A dry
run applies all 84: 2,261 sky objects merge into 1,795 stars.

Refs #670

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* feat(catalog-corrections): Steinicke's, NGC 2000.0's, Collinder's, Lyngå's and SAC's errors

The corrections #670 and PRs 2-6 left for PR 7: Steinicke's types,
magnitudes, sizes and Corwin's identifications; NGC 2000.0's misplaced
names; Collinder's positions and sizes; Lyngå's, Caldwell's and Arp's
identifications; SAC's misnamed rows and star types; La Superba's
range. Each cites the audit's verdict or Corwin. A dry run applies all
of them.

Refs #670

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* feat(catalog-corrections): a field correction can clear a magnitude or a size

A split copies its old sky object's values, and a moved identification
can leave a sky object holding another object's magnitude and size,
with no source that gives its own: IC 5281, a double star, would keep
NGC 7466's. `mag = ""` and `size = ""` clear them, with `was`
required as for any field correction; clearing a field that is already
empty is redundant and fails. Rich's decision.

Refs #670

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* feat(catalog-corrections): the judgement calls, decided

NGC 4322 is Corwin's star, with the galaxy's magnitude and size cleared
and V 13.9 moved to NGC 4323; IC 5281's and IC 998's copied values are
cleared, and IC 997 takes the pair's from Steinicke's IC 998 row.
NGC 6847 is C+N. Col 208 joins IC 2488 (Collinder's own
identification), NGC 2029 and NGC 2030 take the Bica sizes at their
positions, and STF 2576 is HIP 97222. The not-found objects Corwin
identifies drop Steinicke's not-found lead from their descriptions.

Refs #670

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* feat(catalog-corrections): check a same_as against the match guard, and a size for finite, positive extents

mrosseel's fault 7 on #670 (#672's correction checks):

- A correction's size must parse to finite, positive extents. "nan",
  "inf", "0" and "-5" parsed as floats and passed strict parsing. The
  empty size = "" still clears a size.
- A same_as must pass the loaders' match guard, from the listing's own
  type and position (those of the sky object it leaves) to the sky object
  it joins, as corrected in the same pass. Before, ["Lyn 919"] same_as =
  "NGC 224" passed at 100 degrees from the listing.
- guard = false opts out a cited identification whose listing's position
  or type is wrong. It is valid only with a same_as, and on a same_as the
  guard accepts it is redundant and fails.
- own_object gets no guard: its new sky object starts at the old
  position, and any field it moves carries its own was.

Four shipped same_as fail the guard, each a cited identification with
the source's position wrong, and now carry guard = false: Col 208 =
IC 2488 (Collinder's Dec slip, 43'), Lyn 866 = NGC 6846 (Lynga's Dec
slip, 2 degrees), Lyn 639 = Col 285 (one moving group with two centres,
Rich's decision on #680), and NGC 6138 = NGC 6363 (Steinicke's row is on
NGC 6141, 11 degrees away; Corwin).

ADR 0046 decisions 3 and 6, catalog.md 9.5 and the corrections README
say so.

Refs #670

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(catalog-corrections): IC 2145 is NGC 2086, not a 0.2' size

mrosseel's fault 8 on #670: #681 listed IC 2145 2' -> 0.2' citing Bica,
but the vendored Bica row NGC2086,IC2145,LMC-N160C gives 0.85'x0.80'.
The 0.2' is SIMBAD's 0.19' for the cluster, which the audit carried
over from OpenNGC; no source this correction cites gives it.

Corwin identifies IC 2145 with NGC 2086, and Bica names both in one row.
PiFinder keeps them as two sky objects 0.97' apart, so the size
correction becomes same_as = "NGC 2086", which already holds Bica's
0.85'x0.80'.

Refs #670

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(catalog-corrections): refresh after #691 and #692

#692's star matching replaces the 85 hip corrections with its list
of 64, judged on independent evidence. SaM 693 (STF 2576 = HIP 97222),
this PR's own addition, is kept: no rule finds it. 20 fewer tables.

Every was is refreshed against a build of main (4da2a0a) with the
hip corrections. One value moved: La Superba's magnitude, now
Hipparcos's V 5.42 (#691) instead of SAC's 4.8.

#691's WGSN names make four name parts redundant: SaM 1771's preferred
Jabbah, and the added Hatysa, Asellus Australis and Alrescha. The
tables keep their removals of SAC's misspellings.

Refs #670

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(catalog-corrections): four SAC red variables, Gumala, and SaM 1773's Laseth

#692's V gate on rule 1 leaves five SAC red variables unmatched (#691's
"Left for PR 7"). Four rows name an HD or BD number that SIMBAD gives
as their Hipparcos star, so each gets a hip correction:

- T Dra (SaR 139) = HIP 87820, with its GCVS V range [7.2, 13.5];
- BE CMa (SaR 96) = HIP 35865, with its GCVS V range [8.6, 9.4];
- Z Lup (SaR 187) = HIP 71386 and NY Gem (SaR 155) = HIP 31829, which
  take Hipparcos's V through #691 (GCVS gives photographic ranges only).

BE CMi (SaR 98) is left: SIMBAD has HIP 37022 as another star, 46"
away, and SAC's 8.7 lies inside its GCVS V range.

WDS 99456 (LLO 18) is HIP 94645, Gumala: 1.4" from it, and WDS's note
K marks its 4.94 as a K-band magnitude, so the V gate refused it.

#692 split SaM 1773 (nu Sco's CD row) off the system, so SaM 1771's
removal of the misspelled 'Laseth' no longer reached it. SaM 1773 now
has its own removal.

Refs #670

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant